1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E9441429E21
\r
6 for <notmuch@notmuchmail.org>; Mon, 28 Nov 2011 10:12:10 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id ICSJoau02OgO for <notmuch@notmuchmail.org>;
\r
17 Mon, 28 Nov 2011 10:12:10 -0800 (PST)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 2725C431FB6
\r
22 for <notmuch@notmuchmail.org>; Mon, 28 Nov 2011 10:12:10 -0800 (PST)
\r
23 Received: by bkaq10 with SMTP id q10so9667281bka.26
\r
24 for <notmuch@notmuchmail.org>; Mon, 28 Nov 2011 10:12:08 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=3gHVpLnqY9T6vQ51sMlLpsQNdQputLPznIkSDWoiz9Q=;
\r
29 b=h1D/0IqaHLyuRBI3lcHYLC9AxaAkSlzR7Mt/6gTuPcKVn02M5hzaL9nCXXUmG/zbJu
\r
30 /PSXpcl3jyWhEQU1r5muoC1hZyWNOJD7IPhWsdHu2/kE178KBvdWo7XtzlWWAVe7fW8U
\r
31 UgwI+dLzpm0FjMpD/MlTC93bRoh9qTdXWILzg=
\r
32 Received: by 10.205.126.13 with SMTP id gu13mr46750171bkc.114.1322503928517;
\r
33 Mon, 28 Nov 2011 10:12:08 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id hy13sm31266315bkc.0.2011.11.28.10.12.06
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Mon, 28 Nov 2011 10:12:06 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
40 notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show
\r
42 In-Reply-To: <87lir0xr3g.fsf@servo.finestructure.net>
\r
43 References: <1322259811-10834-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
44 <87lir0xr3g.fsf@servo.finestructure.net>
\r
45 User-Agent: Notmuch/0.10+45~g5da8b3d (http://notmuchmail.org) Emacs/23.3.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Mon, 28 Nov 2011 22:11:43 +0400
\r
48 Message-ID: <87mxbgw200.fsf@gmail.com>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Mon, 28 Nov 2011 18:12:11 -0000
\r
67 On Mon, 28 Nov 2011 06:24:19 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
68 > On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
69 > > -(defun notmuch-show-get-header (header)
\r
70 > > +(defun notmuch-show-get-header (header &optional props)
\r
71 > > "Return the named header of the current message, if any."
\r
72 > > - (plist-get (notmuch-show-get-prop :headers) header))
\r
73 > > + (plist-get (notmuch-show-get-prop :headers props) header))
\r
75 > Hey, Dmitry. It looks like the new plist-get call is assuming props is
\r
76 > defined, but it looks like it's only optional in the argument list.
\r
77 > Wouldn't the function fail if the props argument is not supplied?
\r
80 If props is not supplied it is bound to nil. There is no special
\r